Skip to content

Conversation

@acouvreur
Copy link
Contributor

parseID now ensures that there is at least count parts in the string ID. It then joins the extra together

Resolves #3105

Before the change?

  • parseID2 errors with ID: "part1:part2:part3"

After the change?

  • parseID2 returns: "part1" and "part2:part3"

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

It actually fix a breaking change that some values have the separator.


parseID now ensures that there is at least count parts in the string ID. It then joins the extra together

Closes integrations#3105
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: environments cannot have : charcaters

1 participant