chore: Refactor integration tests #2986

stevehipwell · 2025-12-08T22:43:53Z

Resolves #2983
Resolves #2984
Resolves #2985
Resolves #3006
Closes #2941

Before the change?

The acceptance tests are complicated and some are broken
Some of the code is incorrect

After the change?

Acceptance tests have been refactored
- Fewer tests
- Simpler test structure
- Test env setup has been made more granular and documented
Acceptance tests have been run
- Some tests that require paid features haven't been run yet

Pull request checklist

Schema migrations have been created if needed (example)
Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Yes
No

github-actions · 2025-12-08T22:44:01Z

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

deiga

Half-way through, looking good so far!

github/data_source_github_branch_test.go

github/data_source_github_ref_test.go

github/data_source_github_repository_file_test.go

github/data_source_github_rest_api_test.go

github/data_source_github_team_test.go

github/data_source_github_users_test.go

CONTRIBUTING.md

github/resource_github_repository_collaborator_test.go

github/acc_test.go

GNUmakefile

deiga

There are a couple tests commented out in this PR. They seem to cover functionality which isn't covered otherwise, are those just WIP refactoring or is there some other purpose?

stevehipwell · 2026-01-06T18:34:52Z

@nickfloyd @deiga I think this PR is ready to be merged. All of the tests I'm able to run locally have been run and passed.

nickfloyd

Only found one super small thing! 👍

github/test-fixtures/README.md

github/resource_github_repository_collaborator_test.go

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>

@deiga

Per code review feedback from @deiga (integrations#2514 (comment)), this updates the github_release_asset data source tests to use the new testing patterns implemented in integrations#2986 This was tested via: ``` $ TF_ACC=1 \ go test -v ./... -run ^TestAccGithubReleaseAssetDataSource ? github.com/integrations/terraform-provider-github/v6 [no test files] === RUN TestAccGithubReleaseAssetDataSource === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID --- PASS: TestAccGithubReleaseAssetDataSource (5.91s) --- PASS: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID (5.91s) PASS ok github.com/integrations/terraform-provider-github/v6/github 6.788s ``` Signed-off-by: Mike Ball <mikedball@gmail.com>

@deiga

Per code review feedback from @deiga (integrations#2514 (comment)), this updates the github_release_asset data source tests to use the new testing patterns implemented in integrations#2986 This was tested via: ``` $ TF_ACC=1 \ go test -v ./... -run ^TestAccGithubReleaseAssetDataSource ? github.com/integrations/terraform-provider-github/v6 [no test files] === RUN TestAccGithubReleaseAssetDataSource === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID --- PASS: TestAccGithubReleaseAssetDataSource (5.91s) --- PASS: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID (5.91s) PASS ok github.com/integrations/terraform-provider-github/v6/github 6.788s ``` Signed-off-by: Mike Ball <mikedball@gmail.com>

@deiga

Per code review feedback from @deiga (integrations#2514 (comment)), this updates the github_release_asset data source tests to use the new testing patterns implemented in integrations#2986 This was tested via: ``` $ TF_ACC=1 \ go test -v ./... -run ^TestAccGithubReleaseAssetDataSource ? github.com/integrations/terraform-provider-github/v6 [no test files] === RUN TestAccGithubReleaseAssetDataSource === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID --- PASS: TestAccGithubReleaseAssetDataSource (5.91s) --- PASS: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID (5.91s) PASS ok github.com/integrations/terraform-provider-github/v6/github 6.788s ``` Signed-off-by: Mike Ball <mikedball@gmail.com>

stevehipwell requested a review from nickfloyd December 8, 2025 22:43

stevehipwell self-assigned this Dec 8, 2025

stevehipwell had a problem deploying to acctest-dotcom December 8, 2025 22:43 — with GitHub Actions Error

stevehipwell force-pushed the refactor-integration-tests branch from 64384d9 to a3a1145 Compare December 8, 2025 22:44

stevehipwell had a problem deploying to acctest-dotcom December 8, 2025 22:44 — with GitHub Actions Failure

stevehipwell had a problem deploying to acctest-dotcom December 8, 2025 22:44 — with GitHub Actions Error

stevehipwell force-pushed the refactor-integration-tests branch from a3a1145 to 79637e0 Compare December 8, 2025 22:46

stevehipwell had a problem deploying to acctest-dotcom December 8, 2025 22:46 — with GitHub Actions Error

stevehipwell force-pushed the refactor-integration-tests branch from 79637e0 to 8f8da76 Compare December 8, 2025 22:47

stevehipwell had a problem deploying to acctest-dotcom December 8, 2025 22:48 — with GitHub Actions Error

stevehipwell temporarily deployed to acctest-dotcom December 8, 2025 22:48 — with GitHub Actions Inactive

deiga reviewed Dec 9, 2025

View reviewed changes

stevehipwell force-pushed the refactor-integration-tests branch from 8f8da76 to d6872d3 Compare December 9, 2025 10:29

stevehipwell had a problem deploying to acctest-dotcom December 9, 2025 10:29 — with GitHub Actions Failure

stevehipwell temporarily deployed to acctest-dotcom December 9, 2025 10:29 — with GitHub Actions Inactive

stevehipwell force-pushed the refactor-integration-tests branch from d6872d3 to b273abd Compare December 9, 2025 12:29

stevehipwell had a problem deploying to acctest-dotcom December 9, 2025 12:30 — with GitHub Actions Failure

stevehipwell temporarily deployed to acctest-dotcom December 9, 2025 12:30 — with GitHub Actions Inactive

stevehipwell force-pushed the refactor-integration-tests branch from b273abd to 337b854 Compare December 9, 2025 14:28

stevehipwell added the acctest For CI / automated testing label Dec 9, 2025

stevehipwell had a problem deploying to acctest-dotcom December 9, 2025 14:28 — with GitHub Actions Error

stevehipwell deployed to acctest-dotcom December 19, 2025 16:56 — with GitHub Actions Active

deiga reviewed Dec 24, 2025

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

deiga reviewed Dec 24, 2025

View reviewed changes

github/resource_github_repository_collaborator_test.go Outdated Show resolved Hide resolved

deiga reviewed Dec 24, 2025

View reviewed changes

github/acc_test.go Show resolved Hide resolved

deiga reviewed Dec 24, 2025

View reviewed changes

GNUmakefile Show resolved Hide resolved

deiga reviewed Dec 26, 2025

View reviewed changes

deiga mentioned this pull request Jan 5, 2026

feat: add github_release_asset data source #2514

Open

4 tasks

stevehipwell force-pushed the refactor-integration-tests branch from 450176c to dad0a7a Compare January 6, 2026 16:05

stevehipwell had a problem deploying to acctest-dotcom January 6, 2026 16:05 — with GitHub Actions Error

stevehipwell added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed acctest For CI / automated testing labels Jan 6, 2026

stevehipwell force-pushed the refactor-integration-tests branch from dad0a7a to a8b2ec7 Compare January 6, 2026 17:31

stevehipwell force-pushed the refactor-integration-tests branch 2 times, most recently from 794ec78 to 539f914 Compare January 6, 2026 18:52

nickfloyd previously approved these changes Jan 6, 2026

View reviewed changes

github/test-fixtures/README.md Outdated Show resolved Hide resolved

stevehipwell dismissed nickfloyd’s stale review via 72a2758 January 6, 2026 19:18

deiga approved these changes Jan 6, 2026

View reviewed changes

github/resource_github_repository_collaborator_test.go Outdated Show resolved Hide resolved

stevehipwell force-pushed the refactor-integration-tests branch from cfc7aa4 to 241055a Compare January 6, 2026 19:58

chore: Refactor integration tests

581b507

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>

stevehipwell force-pushed the refactor-integration-tests branch from 241055a to 581b507 Compare January 6, 2026 20:01

nickfloyd self-requested a review January 6, 2026 20:05

nickfloyd approved these changes Jan 6, 2026

View reviewed changes

stevehipwell merged commit dd299da into main Jan 6, 2026
8 checks passed

stevehipwell deleted the refactor-integration-tests branch January 6, 2026 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Refactor integration tests #2986

chore: Refactor integration tests #2986

Uh oh!

stevehipwell commented Dec 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

deiga left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deiga left a comment

Uh oh!

stevehipwell commented Jan 6, 2026

Uh oh!

nickfloyd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore: Refactor integration tests #2986

chore: Refactor integration tests #2986

Uh oh!

Conversation

stevehipwell commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

deiga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deiga left a comment

Choose a reason for hiding this comment

Uh oh!

stevehipwell commented Jan 6, 2026

Uh oh!

nickfloyd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stevehipwell commented Dec 8, 2025 •

edited

Loading