fix(ui-text-input,emotion): fix TextInput displaying double focus rings when a focusable element is rendered inside #2347
+30
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs when a focusable element is rendered inside It was using a :focus-within selector, but this was not a good solution when the TextInput contained a focusable element. The new solution only displays the component's focus ring if an input is focused, preventing double focus
matyasf
force-pushed
the
textinput_focus_fix
branch
from
37b729d to
6e13703
Compare
|
joyenjoyer
approved these changes
Jan 14, 2026
ToMESSKa
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using a
:focus-within selector, but this was not a good solution when the TextInput contained a focusable element.The new solution only displays the component's focus ring if an input is focused, preventing double focus.
To test: Check out examples of TextInput and components that use it (DateInput, Select, ..) that it displays focus rings correctly when clicked or tabbed in with keyboard. The 'password' example in TextInput was broken in the previous version