[v12] feat(ui-popover): rework Popover #2334
Merged
+11
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INSTUI-4801
|
ToMESSKa
commented
Jan 7, 2026
| - theme variable `colorError` has been renamed to `errorTextColor` | ||
| - theme variable `colorSuccess` has been renamed to `successTextColor` | ||
| - theme variable `errorIconMarginRight` is now removed | ||
| - `newError` message type is now deprecated. Both `newError` and the original `error` type now behave identically (using the new implementation that was previously exclusive to `newError`) |
Contributor
Author
There was a problem hiding this comment.
these comments were missing from this PR: #2273
ToMESSKa
changed the title
matyasf
approved these changes
Jan 8, 2026
adamlobler
approved these changes
Jan 9, 2026
balzss
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4801
ISSUE:
TEST PLAN: