(strict) typing for __init__.py, mpi.py, graph.py #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
typing-record
branch
3 times, most recently
from
71cadf4 to
94b706b
Compare
matthiasdiener
force-pushed
the
typing-record
branch
from
94b706b to
8a14dfb
Compare
matthiasdiener
force-pushed
the
typing-record
branch
from
5494abf to
953870b
Compare
matthiasdiener
changed the title
Contributor
Author
|
This is ready for review. I can break the changes into smaller pieces if you prefer. |
matthiasdiener
commented
Mar 14, 2023
| return result | ||
| comb = MovedFunctionDeprecationWrapper(math.comb, deadline=2023) | ||
|
|
||
| def perm(n: SupportsIndex, # type: ignore[misc] |
Contributor
Author
There was a problem hiding this comment.
I removed this function since pytools requires Python 3.8+ currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.