Entropy stable DG and flux-differencing #214

thomasgibson · 2022-01-14T05:17:17Z

Requires the lazy array context provided in: [Lazy evaluation] Pytato Array Context with transformations meshmode#248
Requires the features of this loopy fork: https://github.com/kaushikcfd/loopy/tree/pytato-array-context-transforms

grudge/projection.py

inducer

(Comments from our meeting)

grudge/models/euler.py

grudge/flux_differencing.py

inducer · 2022-01-25T21:54:56Z

grudge/flux_differencing.py

+
+        faces = faces_for_shape(base_grp.shape)
+        nfaces = len(faces)
+        # NOTE: assumes same quadrature rule on all faces


Code this as an assert.

grudge/flux_differencing.py

inducer

More comments from (the second half) of our meeting

grudge/models/euler.py

inducer · 2022-01-25T23:27:13Z

grudge/models/euler.py

+                                           _reshape((1, -1), qtilde_allquad),
+                                           _reshape((-1, 1), qtilde_allquad),


Try actx.np.reshape.

grudge/models/euler.py

inducer · 2022-01-25T23:44:11Z

grudge/models/euler.py

+                                           _reshape((1, -1), qtilde_allquad),
+                                           _reshape((-1, 1), qtilde_allquad),


(i.e. there's some benefit to doing this operator-ly)

grudge/models/euler.py

inducer · 2022-01-26T22:53:41Z

grudge/models/euler.py

+    mass_flux = rho_mean * u_avg
+    momentum_flux = np.outer(mass_flux, u_avg) + np.eye(dim) * p_mean
+    energy_flux = (


_flux_div here?

grudge/models/euler.py

grudge/flux_differencing.py

grudge/models/euler.py

inducer · 2022-01-26T23:23:47Z

test/test_sbp_ops.py

+        q_mats = [p_mat.T @ (weights * vdm_q.T @ vdm_q) @ diff_mat @ p_mat
+                  for diff_mat in diff_matrices(vgrp)]
+        e_mat = vf_mat @ p_mat
+        qtilde_mats = 0.5 * np.asarray(
+            [np.block([[q_mats[d] - q_mats[d].T, e_mat.T @ b_mats[d]],
+                       [-b_mats[d] @ e_mat, b_mats[d]]])
+             for d in range(dcoll.dim)]
+        )


Not loving that this repeats code from the hybridized op implementation.

test/test_euler_model.py

test/test_euler_flux_differencing.py

inducer · 2023-04-14T01:46:14Z

See #306 for an initial attempt at updating this for modern-day grudge.

This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>

inducer · 2023-06-23T14:15:18Z

Closing in favor of #306.

This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>

thomasgibson added 17 commits January 13, 2022 22:05

Add projection/interpolation operators

5e528b2

Add unit test for SBP properties

8cf4912

Use SingleGridWorkBalancingPytatoArrayContext

fca7f46

Add entropy stable Euler model and flux-differencing

7499e9f

Test variable transformations in Euler module

cb555a5

Set up ESDG in vortex example

b0eb50a

Update requirements.txt to point to the development branches

956d305

Add esdg option for pulse problem

b510e27

Add lsrk methods to shortcuts

cf7eead

Readd 1-D Sod shock problem

63b1ef0

Taylor Green vortex experiment

eeadc03

Clean up and document taylor green experiment

8fe4f64

Revamp helper function for flux-differencing

37acb38

Refactor flux computations

d2f634c

Update ESDG Euler operator using Euler-specific array container

676e3a2

Clean up modules, examples, and add convergence test

4c9dcc9

Reuse reference mass matrix routine in projection

58681b4

inducer reviewed Jan 25, 2022

View reviewed changes

grudge/projection.py Outdated Show resolved Hide resolved

inducer reviewed Jan 25, 2022

View reviewed changes

inducer reviewed Jan 26, 2022

View reviewed changes

thomasgibson force-pushed the flux-differencing branch from 140bef0 to 7de0c41 Compare January 26, 2022 02:33

Clean up quadrature projection routine

48cfae2

thomasgibson force-pushed the flux-differencing branch from 7de0c41 to 48cfae2 Compare January 26, 2022 02:44

inducer reviewed Jan 26, 2022

View reviewed changes

thomasgibson added 3 commits January 27, 2022 12:54

Reuse divergence helper in flux-differencing function

d463025

Clean up flux-differencing module

9ba57df

Clean up interpolation operators

f9142f4

thomasgibson force-pushed the flux-differencing branch from 9c40c3c to f9142f4 Compare January 27, 2022 21:54

Clean up boundary condition application

b6206af

Clean and combine Euler ESDG tests

a67fd1e

thomasgibson added the mirgecom production Developments critical to MIRGECom label Jan 28, 2022

thomasgibson force-pushed the flux-differencing branch from 927da01 to 09d2027 Compare January 28, 2022 03:09

Overhaul/refactor of Euler models

7de9f81

thomasgibson force-pushed the flux-differencing branch from 09d2027 to 7de9f81 Compare January 28, 2022 03:15

Document flux differencing and related functions

26d364b

thomasgibson marked this pull request as ready for review January 28, 2022 04:52

inducer mentioned this pull request Apr 14, 2023

Entropy stable DG and flux-differencing #306

Draft

2 tasks

inducer added a commit that referenced this pull request Apr 14, 2023

Entropy stable DG and flux-differencing

dc8d8dc

This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>

inducer added a commit that referenced this pull request Apr 14, 2023

Entropy stable DG and flux-differencing

c7457c5

This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>

inducer added a commit that referenced this pull request Jun 23, 2023

Entropy stable DG and flux-differencing

56de20d

This is #214 squashed and rebased. Co-authored-by: Andreas Kloeckner <inform@tiker.net>

inducer closed this Jun 23, 2023

inducer deleted the flux-differencing branch June 23, 2023 14:16

		_reshape((1, -1), qtilde_allquad),
		_reshape((-1, 1), qtilde_allquad),

Entropy stable DG and flux-differencing #214

Entropy stable DG and flux-differencing #214

Uh oh!

Conversation

thomasgibson commented Jan 14, 2022

Uh oh!

Uh oh!

inducer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducer Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

inducer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

inducer Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducer Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

inducer Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducer Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inducer commented Apr 14, 2023

Uh oh!

inducer commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants