Skip to content

ci: pin jax<0.4.31 for mypy on gitlab #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 1 commit into from
Aug 5, 2024
Merged

ci: pin jax<0.4.31 for mypy on gitlab #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,14 @@ Pylint:

Mypy:
script: |
EXTRA_INSTALL="jax[cpu]"
# NOTE: jax>=0.4.31 requires python 3.10 and uses pattern matching
# which conflicts with our mypy.python_version = '3.8' setting
EXTRA_INSTALL="mypy pytest jax[cpu]<0.4.31"

curl -L -O https://tiker.net/ci-support-v0
. ./ci-support-v0

build_py_project_in_venv
python -m pip install mypy pytest
./run-mypy.sh
tags:
- python3
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ known-local-folder = [
lines-after-imports = 2

[tool.mypy]
# TODO: unpin jax version on CI when this gets bumped to 3.10
python_version = "3.8"
warn_unused_ignores = true
# TODO: enable this
Expand Down