Add a pass to outline computations in a function #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
force-pushed
the
outlining
branch
5 times, most recently
from
c00aaff to
cf87fd4
Compare
majosm
force-pushed
the
outlining
branch
2 times, most recently
from
858e1c4 to
b134b64
Compare
majosm
force-pushed
the
outlining
branch
2 times, most recently
from
7663f97 to
92e51f2
Compare
majosm
force-pushed
the
outlining
branch
2 times, most recently
from
7024ca2 to
be021fe
Compare
majosm
force-pushed
the
outlining
branch
8 times, most recently
from
1100ca3 to
4a52bdc
Compare
majosm
force-pushed
the
outlining
branch
2 times, most recently
from
e54a56e to
befb2d3
Compare
Collaborator
|
Depends on |
Collaborator
|
@inducer Do you know what's up with these doc errors? I don't get them when building locally. Otherwise, this looks ready for review. |
inducer
force-pushed
the
outlining
branch
5 times, most recently
from
96eb003 to
2a6a488
Compare
cosmetic-ish refactor of OutlinedCall.__call__ includes minor change to handle array containers that contain scalars (e.g., a TracePair of constant diffusion coefs) check for non-argument placeholders in outlined function drop unused function arguments pass hashable instead of string as id to outline handle optional arguments that are passed as None explicitly change Map -> immutabledict in outlining remove duplicates when creating FunctionDefinition add comment explaining non-argument placeholder check Co-authored-by: Matthew Smith <mjsmith6@illinois.edu> Co-authored-by: Andreas Kloeckner <inform@tiker.net>
… to inline functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlining is as simple as decorating a function with
@actx.outline.Draft because:
Add more precise typing to transformation functions pytato#609Mapper typing: Array->Array, Names->Names pytato#610.