Skip to content

Initial stab at actx.trace_call #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MTCam wants to merge 6 commits into from
Closed

Initial stab at actx.trace_call #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2dde87
Initial stab at actx.trace_call
MTCam Dec 13, 2022
198d2cf
Merge remote-tracking branch 'origin/main' into trace-call
MTCam Dec 20, 2022
968b5d3
Merge with inducer/main
MTCam Jan 19, 2023
5472972
add (commented) output parsing section
MTCam Jan 19, 2023
61af2e1
discover content of output_template
MTCam Mar 11, 2023
f055987
Merge remote-tracking branch 'origin/main' into mrg-upstream
MTCam Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions arraycontext/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,12 @@ def compile(self, f: Callable[..., Any]) -> Callable[..., Any]:
"""
return f

# Supporting interface for function/call tracing in actx implementations
def trace_call(self, f: Callable[..., Any],
*args, identifier=None, **kwargs):
Copy link
Owner

@inducer inducer Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return type annotation. More generally, trace_call really should permit the user to do two things:

  • Use the result of the traced call.
  • Call the trace result using new data.

I'm not sure we'll be able to do both with just a single return value.

Copy link
Owner

@inducer inducer Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also want the interface to apply tags to the call site.

"""Returns the result of the called function *f* with the specified args."""
return f(*args, **kwargs)

# undocumented for now
@property
@abstractmethod
Expand Down
Loading