Crosslink 198 initial #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss and
jakub-id
as code owners
jakub-id
reviewed
Jan 29, 2026
| func (a *PatronRequestApiHandler) GetPatronRequests(w http.ResponseWriter, r *http.Request, params proapi.GetPatronRequestsParams) { | ||
| symbol, err := api.GetSymbolForRequest(r, a.tenant, params.XOkapiTenant, params.Symbol) | ||
| logParams := map[string]string{"method": "GetPatronRequests", "side": params.Side, "symbol": symbol} | ||
| func (a *PatronRequestApiHandler) GetStateModelModelsReturnables(w http.ResponseWriter, r *http.Request) { |
Contributor
There was a problem hiding this comment.
@kurtnordstrom let's bundle returnables.yaml with the app and unmarshal here and serialize on GET
| InvokeAction(common.ExtendedContext, events.Event) | ||
| } | ||
|
|
||
| type ReturnablesPatronRequestActionService struct { |
Contributor
There was a problem hiding this comment.
@kurtnordstrom action mapping service should not be state model specifc, it's just a collection of all action implementationsthat can be used in a specific state model
| - actionResult | ||
|
|
||
| paths: | ||
| /state_model/models/returnables: |
Contributor
There was a problem hiding this comment.
@kurtnordstrom let's not harcode the state model name in the path but match the {name} against the bundled file name
| } | ||
|
|
||
| /* Constructor function to initialize the mappings for the returnables */ | ||
| func NewReturnableActionMapping() *ReturnableActionMapping { |
Contributor
There was a problem hiding this comment.
@kurtnordstrom let's pass StateModel to the constructor to set up the mapping and drop the ReturnableActionMapping concrete impl since, I think, it will all be controlled via the StateModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.