Add support for ignoring progess bar and status line updates.#203
Open
Sethur wants to merge 1 commit intoimagej:masterfrom
Open
Add support for ignoring progess bar and status line updates.#203Sethur wants to merge 1 commit intoimagej:masterfrom
Sethur wants to merge 1 commit intoimagej:masterfrom
Conversation
Added flag for ignoring all subsequent status line and progress bar updates. Useful for calling plugins from other plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a flag for ignoring all subsequent status line and progress bar updates in
IJ.java.The motivation was that currently, when calling/running any plugin A from within another plugin B, and A writes its own updates to the status line or progress bar, there can be the following issues:
I tried "protecting" the status bar by posting messages beginning with
!, but this will get deactivated across threads. When it comes to the progress bar, I tried to call thesetBatchMode(...)method of the main ProgressBar instance manually, but this will get deactivated if any thread was callingIJ.showProgress(int currentIndex, int lastIndex)withcurrentIndex == lastIndex.As a conclusion, there really is no good method of preventing other plugins from cluttering the progress bar and status line, so I thought it would be cleaner to introduce this flag.