[feature] Conditional compilation for SES compatibility#32
Open
veronicaz41 wants to merge 3 commits intoiden3:masterfrom
Open
[feature] Conditional compilation for SES compatibility#32veronicaz41 wants to merge 3 commits intoiden3:masterfrom
veronicaz41 wants to merge 3 commits intoiden3:masterfrom
Conversation
veronicaz41
changed the title
veronicaz41
changed the title
1 task
Contributor
Author
|
cc @phated FYI, this works for us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webwokers are not supported in SES.
See the doc here: https://ses-secure-ecmascript.readthedocs.io/en/stable/getting-started.html#webworkers.
Added conditional compilation to not include Worker related code if env var SES is set.
Also when we run mm-snap eval in the node environment to build the snap,
globalThis.btoais undefined. Even though we want the snap eventually run in the browser environment. So add checking for whetherglobalThis.btoais a function.