Merged
Conversation
- Introduced type to expose an method for cell activation. - Updated component to support forwarding refs and added memoized methods. - Enhanced tests to cover new ref methods, ensuring they are stable and handle invalid points gracefully. - Added a new story for controlled activation demonstrating the use of the ref. This update improves the usability of the Spreadsheet component by allowing parent components to programmatically activate cells.
Owner
|
Wow this is really cool! I don't have the capacity to fully test this at the very moment but I'll try to get to it as soon as possible |
Contributor
Author
|
Sure. |
Pull Request Test Coverage Report for Build 12856572900Details
💛 - Coveralls |
iddan
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Spreadsheet component with ref support and add related tests
SpreadsheetReftype to expose anactivatemethod for cell activation.Spreadsheetcomponent to support forwarding refs and added memoized methods.This update improves the usability of the Spreadsheet component by allowing parent components to programmatically activate cells.
Test case result.