Elasticsearch 8 support #3002
Elasticsearch 8 support #3002
Conversation
Preview of modified filesPreview of modified Markdown: |
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
mnocon
force-pushed
the
elasticsearch-8
branch
from
e91a23b to
f263746
Compare
mnocon
force-pushed
the
elasticsearch-8
branch
from
f263746 to
6463dd5
Compare
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
Thanks for covering the alternative!
ibexa-workflow-automation-1
bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
| ``` | ||
|
|
||
| For more information and a list of available choices, see [Connection pool](https://www.elastic.co/guide/en/elasticsearch/client/php-api/7.x/connection_pool.html). | ||
| For more information and a list of available choices, see [Node pool](https://www.elastic.co/docs/reference/elasticsearch/clients/php/node_pool). |
There was a problem hiding this comment.
Shouldn't we put the link to 7x and 8x clients here?
julitafalcondusza
left a comment
julitafalcondusza
left a comment
There was a problem hiding this comment.
Please check my comments.
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
| The node pool manages the list of active nodes, which can change over time due to connectivity issues, host malfunction, or when you add new nodes to the cluster to increase performance. | ||
|
|
||
| You can change the default setting with the following key: | ||
| By default, Elasticsearch 8 uses `SimpleNodePool` with `RoundRobin` selector and `NoResurrect` strategy. |
There was a problem hiding this comment.
I'd put it differently, because users can opt for either of the supported versions. Something along the lines of:
"In installations running Elasticsearch 8.18+, the default configuration uses SimpleNodePool with a RoundRobin selector and a NoResurrect strategy."
At the same time, I wouldn't remove information that discusses 7.16.2+ configuration, but have both.
Unless of course we want to adamantly say "you must use elastic 8" or at least "Ibexa strongly recommends that you use elastic 8" in all those places where two versions are mentioned, followed by "for 7.16.2+ configuration, refer to our documentation for the v.4.6.x release" (in requirements and a note in install elasticsearch)
There was a problem hiding this comment.
Even if you decide to use Elasticsearch 7 (which we won't recommend anymore), you cannot use the existing configuration - please see the update instructions, the old configuration is deprecated and does nothing.
Regardless of Elasticsearch version, you have to use the "node pool" settings - even when staying on Elasticsearch 7
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
…ch.md Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
5 participants
Doc for https://github.com/ibexa/elasticsearch/pull/70
Target: v5 only