Conversation
|
Hi there, can you resolve the conflicts please. Thanks. Also, it would be great if we don't change the code pattern. |
|
Well, the only reason I did any changes to the code pattern was because eslint gave me 198 errors, all of which are now fixed in this PR.. Will resolve conflicts tonight. |
|
It would be great if this lib had tests, so we could be 100% sure we don't break existing functionality by accident. |
|
@JuhQ Sure thats coming soon, I'll be working on that by this weekend. Also, I appreciate your efforts, but just because we don't have tests for the same, I am bit reluctant for the lib pattern changes. |
|
Totally understood. Let's merge this after there's tests, so I we can be sure this pr doesn't break any existing functionality. I'll rebase and refactor once some tests are implemented. Drop a note on this pr when they are done and I'll start work on that. There's no reason to hurry this pr, better be sure no existing functionality is broken |
|
@JuhQ Great, thanks a lot. I'll update you, once am done with the tests. |
|
@i-break-codes conflicts fixed |
Note, even though I went through the file, fixed all the issues which came up in eslint and added gulp with uglifier, I did not test the code itself. But there shouldn't be any problems.