feat(client/dispatch): try_poll_ready() methods#3892
Closed
cratelyn wants to merge 1 commit intohyperium:masterfrom
Closed
feat(client/dispatch): try_poll_ready() methods#3892cratelyn wants to merge 1 commit intohyperium:masterfrom
try_poll_ready() methods#3892cratelyn wants to merge 1 commit intohyperium:masterfrom
Conversation
this change is motivated by aiming to use interfaces like `hyper::client::conn::http2::SendRequest::try_send_request()` or `hyper::client::conn::http1::SendRequest::try_send_request()` in the context of tower middleware; the `Service<T>` trait's signature is such that the same error type be returned from `Service::poll_ready()` and `Service::call()`. this means that services that might resolve to a recovered message may call `try_poll_ready` when polling for readiness. this avoids making `TrySendError<T>` constructable externally, see hyperium#3883 as an alternate approach that was considered. Signed-off-by: katelyn martin <git@katelyn.world>
Member
Author
|
ci is failing due to some |
cratelyn
added a commit
to cratelyn/hyper
that referenced
this pull request
Jul 29, 2025
this commit introduces a `std::error::Error` implementation for `hyper::client::conn::TrySendError`. this allows callers of `hyper::client::conn::http2::SendRequest::try_send_request()` or `hyper::client::conn::http1::SendRequest::try_send_request()` to box a `TrySendError<T>` without discarding a potentially recovered message. a `std::fmt::Display` implementation is added in this commit, because it is a prerequisite for implementations of `std::error::Error`. for some previous discussion on this topic, see "_other options_" here: hyperium#3883 (comment). Ref: hyperium#3883 Ref: hyperium#3892 Signed-off-by: katelyn martin <git@katelyn.world>
Member
Author
|
closing this for now, in favor of #3922. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change is motivated by aiming to use interfaces like
hyper::client::conn::http2::SendRequest::try_send_request()orhyper::client::conn::http1::SendRequest::try_send_request()in the context of tower middleware; theService<T>trait's signature is such that the same error type be returned fromService::poll_ready()andService::call().this means that services that might resolve to a recovered message may call
try_poll_readywhen polling for readiness.this avoids making
TrySendError<T>constructable externally, see #3883 as an alternate approach that was considered.