feat: impl From<Http1|Http2> for auto::Builder#93
Open
seanmonstar wants to merge 1 commit intomasterfrom
Open
Conversation
dswij
approved these changes
Apr 6, 2024
tottoto
approved these changes
May 9, 2024
Contributor
|
Note on this: Either way the Http[12]Builder only take a mut ref to Builder, so it's possible to change http2 options and go back which I hadn't realized in #113 ; so something like this works: It's a bit less pretty than just chaining operators, but that means there probably isn't any hard need for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is I wanted a way to get back to the main
Builder, and this seemed to do it. Does it make sense?cc @davidpdrsn @programatik29