Fix cargo test ... for a variety of features#266
Open
erickt wants to merge 1 commit intohyperium:masterfrom
Open
Fix cargo test ... for a variety of features#266erickt wants to merge 1 commit intohyperium:masterfrom
cargo test ... for a variety of features#266erickt wants to merge 1 commit intohyperium:masterfrom
Conversation
This patch fixes a number of test combinations that were failing before: * `cargo test` * `cargo test --features client-legacy` * `cargo test --features client-legacy,http1` * `cargo test --features client-legacy,http2` * `cargo test --features client-legacy,http1,http2` I would have expected this to have been caught by `cargo hack` but I'm guessing it wasn't testing at this depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a number of test combinations that were failing before:
cargo testcargo test --features client-legacycargo test --features client-legacy,http1cargo test --features client-legacy,http2cargo test --features client-legacy,http1,http2I would have expected this to have been caught by
cargo hackbut I'm guessing it wasn't testing at this depth.