[DOC] add missing torch entries in README and documentation#239
[DOC] add missing torch entries in README and documentation#239Abhishek9639 wants to merge 1 commit intohyperactive-project:mainfrom
Conversation
|
Hii @SimonBlanke, |
SimonBlanke
left a comment
There was a problem hiding this comment.
@Abhishek9639 Thanks for opening the PR.
The Issue is from a time where the readme looked like this:
https://github.com/hyperactive-project/Hyperactive/tree/2842478bb89325d13809aae7cb3dd44922d8de1c
This is very different (and worse) from now (the current main). So the suggestions made by @fkiraly should have raised some questions, right? It would have been good to task clarifications in the Issue itself.
Because of this the changes in the readme do not make sense. The pytorch integrations is already presented in the 'key features' in the current readme.
Remove your changes in both readmes.
The example and the changes in the docs make sense though. You can leave them.
Description
Added the missing
torchintegration entries in the README feature table and created a full example page for TorchExperiment, following the pattern of existing sklearn/sktime integrations.Related Issues
Fixes #211
Type of Change
[DOC]- Documentation changesHow was this solved?
torchentry to the integrations table in examples/integrations/README.mdHillClimbingoptimizerChecklist
[BUG],[ENH],[DOC]or[MNT]make check(lint, format, isort)Testing
The new example is auto-discovered by examples/test_examples.py and passes.