[DOC] Add docstrings for best_estimator.py#235
Open
omkar-334 wants to merge 1 commit intohyperactive-project:mainfrom
Open
[DOC] Add docstrings for best_estimator.py#235omkar-334 wants to merge 1 commit intohyperactive-project:mainfrom
best_estimator.py#235omkar-334 wants to merge 1 commit intohyperactive-project:mainfrom
Conversation
SimonBlanke
requested changes
Feb 19, 2026
| Only available if ``refit=True`` and the underlying estimator supports | ||
| ``score_samples``. | ||
|
|
||
| .. versionadded:: 0.24 |
| X : indexable, length n_samples | ||
| Must fulfill the input assumptions of the | ||
| underlying estimator. | ||
|
|
Collaborator
There was a problem hiding this comment.
'Xt' is not documented here.
| Returns | ||
| ------- | ||
| y_score : ndarray of shape (n_samples,) | ||
| The ``best_estimator_.score_samples`` method. |
Collaborator
There was a problem hiding this comment.
This should be more detailed.
Collaborator
@omkar-334 I would suggest you run it locally and look into the errors and understand them. If they are relevant or something should be changed you should open an issue for it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds docstrings for
best_estimator.py, from https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/model_selection/_search.pyRelated Issues
Fixes #226
Type of Change
[BUG]- Bug fix (non-breaking change fixing an issue)[ENH]- New feature (non-breaking change adding functionality)[DOC]- Documentation changes[MNT]- MaintenanceHow was this solved?
Checklist
[BUG],[ENH],[DOC]or[MNT]make check(lint, format, isort)Note
@SimonBlanke
make checkis failing because of unused imports, unorganized imports and other issues... Can I take that up too?