This repository was archived by the owner on Feb 19, 2019. It is now read-only.
Allow specifying password to skip dialog#22
Open
rickparrish wants to merge 1 commit intohumphd:masterfrom
Open
Allow specifying password to skip dialog#22rickparrish wants to merge 1 commit intohumphd:masterfrom
rickparrish wants to merge 1 commit intohumphd:masterfrom
Conversation
Contributor
|
In order to prevent a "breaking change" I would recommend leaving public static string GetPassword() as is, and create a new ublic static SecureString GetPassword() accordingly. This way any existing consuming applications can still function, but you can also get the benefits of SecureString. Hopefully other apps would update accordingly to use the new method going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My RDP/VNC client allows storing passwords, so I've modified VncSharp to accept a password as a SecureString, which then allows my client to skip the password prompt dialog for VNC connections.
It would be great if this could be merged -- will make things easier for me to merge future updates to VncSharp, and maybe it would be useful to someone else as well.