-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Fix Wan/WanI2V patchification #13038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@bot /style |
|
Style bot fixed some files and pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left a comment about using self.transformer.config.patch_size instead of hardcoding the patch_size to 2.
As an aside, I think this solution is superior to forcing the height and width to be multiples of 32 because WanPipeline is meant to work with both Wan 2.1 and Wan 2.2 models; because the VAE spatial downsample factor is 8 for the Wan 2.1 models but 16 for Wan 2.2 models, this check would be too restrictive for Wan 2.1 models (which can accept height/width which are multiples of 16 but not 32).
I agree with you for the idea of using `patch_size` instead. Thanks!😊 Co-authored-by: dg845 <58458699+dg845@users.noreply.github.com>
|
@dg845 Hi! Thanks for your suggestion. Sorry that I hardcoded Another potential issue (but unlikely happen) is that |
What does this PR do?
Fixes #13034
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.