Perform in-place zeroing instead of creating new tensors #13037
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this code snippet while reading the pipeline code:
It took me some time to understand what it was doing, and once I did, I noticed that it can be simplified to the following:
This achieves the same result, while being more readable and more efficient (in-place operation, fewer allocations and copies).
I realize the performance gain may not be significant in most cases, but the simpler approach improves clarity and reduces unnecessary tensor operations. There are likely other similar instances in the pipelines that could benefit from the same refactor.
I'd be interested to hear your thoughts on this change and whether it would be worth applying more broadly.