fix: GHPullRequestReviewComment.getLine() returning -1 #2188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refresh()method to fetch complete comment data from the APIProblem
When fetching review comments through
review.listReviewComments(), thegetLine()method always returns -1. This is because the GitHub API endpoint/repos/{owner}/{repo}/pulls/{pull_number}/reviews/{review_id}/commentsdoes not returnline,original_line,side, and related fields.Solution
refresh()method - ImplementsRefreshableinterface, allowing users to fetch complete comment data:getLine(),getSide(), and related methods explaining when -1/UNKNOWN is returned.Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: