Fixed the issue where field values containing spaces were being rejected with an unhelpful error message (#1665)#1682
Open
SandeepaInduwaraSamaranayake wants to merge 1 commit intohttpie:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue @d0niek reported #1665:
http --print=B POST api.url.com field_name="Foo Bar"Would fail with the error:
This happens when shell argument parsing splits the improperly quoted arguments, causing 'Bar' to be passed as a separate argument without a separator (=, :, @, etc.).
The Fix:
Improved the error handling in to provide a more helpful error message:
Added comprehensive tests in to cover:
test_invalid_item_without_separator_provides_helpful_error - Ensures the helpful error message appears
test_values_with_spaces_when_properly_quoted - Tests three scenarios with properly quoted values containing spaces:
Verification