This repository was archived by the owner on Feb 3, 2023. It is now read-only.
hc: Update to 2018 edition #2011
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR
hc'sCargo.tomlto use the 2018 edition of Rust (74f04b2)usedeclarations caused by the changes to namespacing in the 2018 edition (74f04b2)extern crates because the 2018 edition makes them unneeded (74f04b2)#[macro_use] extern crates and addsusedeclarations for their macros where needed (1693930)#[warn(unused_extern_crates)]because there are no longer anyextern cratedeclarations (50c68b0)extern crates should be the default...usedeclarations for clarity (fc1b594)testing/benchmarking notes
N/A
followups
I'm currently working on one of these for
holochain_core_typesas well.changelog
documentation