Skip to content

Fix charset encoding header #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinr1234 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix charset encoding header #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ router.applyMiddleware = () => {
if (req.headers.accept) {
// 406 Not Acceptable
let matchingTypes = req.headers.accept.split(/, ?/)
matchingTypes = matchingTypes.filter(mediaType => // Accept application/*, */vnd.api+json, */* and the correct JSON:API type.
mediaType.match(/^(\*|application)\/(\*|json|vnd\.api\+json)$/) || mediaType.match(/\*\/\*/))
matchingTypes = matchingTypes.filter(mediaType => {
// Remove charset encoding
const type = mediaType.split(';')[0]
// Accept application/*, */vnd.api+json, */* and the correct JSON:API type.
return type.match(/^(\*|application)\/(\*|json|vnd\.api\+json)$/) || type.match(/\*\/\*/)
})

if (matchingTypes.length === 0) {
return res.status(406).end()
Expand Down