Fix: Bypass authentication for Telegram webhook to enable bot functionality#8
Open
talesam wants to merge 1 commit intohiddify:mainfrom
Open
Fix: Bypass authentication for Telegram webhook to enable bot functionality#8talesam wants to merge 1 commit intohiddify:mainfrom
talesam wants to merge 1 commit intohiddify:mainfrom
Conversation
Author
|
@Iam54r1n4 Could you check my PR? I had opened an Issue saying there was a problem with the bot, they ignored me, so I went after solving the problem. |
Author
|
@HiddifyOfficial See! |
Contributor
|
This line will create a security issue the requests should be within the proxy path otherwise it may creates an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Telegram bot functionality is broken due to authentication requirements on the webhook endpoint. This PR fixes the issue by bypassing authentication specifically for Telegram webhook requests.
Problem:
The Telegram bot's webhook requests are being blocked by the panel's authentication middleware, resulting in HTTP 500 errors. This happens because Telegram's servers cannot provide the authentication credentials required by our middleware.
Technical Details:
Solution:
Added a specific exception in the base_middleware to bypass authentication for Telegram webhook requests. This is a secure approach because:
Alternative approaches considered:
Testing: