Skip to content

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 15, 2025

Fixes #2437
Fixes #2435

TODO

  • fix asClass without instance
  • fix downstream plugins depending on classes
  • breaking change in method name builder (added first argument)
  • expose class splitting strategy
  • add casing options to method name and class name builders
  • rename method name and class name builders
  • rename stringCase interfaces?
  • add changelog for codegen-core fix local names
  • document output.header

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

🦋 Changeset detected

Latest commit: 815a3de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/openapi-ts Minor
@hey-api/codegen-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Jan 2, 2026 4:38am

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 17.38599% with 2029 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.09%. Comparing base (4689b68) to head (815a3de).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...napi-ts/src/plugins/@angular/common/shared/node.ts 2.12% 415 Missing ⚠️
...ges/openapi-ts/src/plugins/@hey-api/sdk/v1/node.ts 3.44% 308 Missing ⚠️
...i-ts/src/plugins/@hey-api/sdk/operations/config.ts 55.05% 80 Missing ⚠️
...rc/plugins/@hey-api/typescript/shared/operation.ts 1.38% 71 Missing ⚠️
...s/openapi-ts/src/plugins/@angular/common/plugin.ts 6.34% 59 Missing ⚠️
...src/plugins/@angular/common/httpRequests/config.ts 1.69% 58 Missing ⚠️
...rc/plugins/@angular/common/httpResources/config.ts 1.69% 58 Missing ⚠️
...s/src/plugins/@hey-api/typescript/shared/export.ts 2.00% 49 Missing ⚠️
...enapi-ts/src/openApi/shared/locations/operation.ts 26.78% 41 Missing ⚠️
...s/openapi-ts/src/plugins/@hey-api/sdk/v1/plugin.ts 6.81% 41 Missing ⚠️
... and 105 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
+ Coverage   32.83%   33.09%   +0.26%     
==========================================
  Files         430      440      +10     
  Lines       34126    34420     +294     
  Branches     2157     2212      +55     
==========================================
+ Hits        11204    11393     +189     
- Misses      22894    22997     +103     
- Partials       28       30       +2     
Flag Coverage Δ
unittests 33.09% <17.38%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@3109
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@3109
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@3109
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@3109

commit: 815a3de

@opswiz
Copy link

opswiz commented Dec 24, 2025

For, #2437 (comment)

Sure @mrlubos Will test the new PR.

Commenting here to keep the conversation here to submit any feedback if applicable

@mrlubos
Copy link
Member Author

mrlubos commented Dec 24, 2025

I'm still polishing but yeah let me know!

@mrlubos mrlubos marked this pull request as ready for review January 2, 2026 04:39
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug 🔥 Broken or incorrect behavior. labels Jan 2, 2026
@mrlubos mrlubos changed the title fix(@hey-api/sdk): dedup classes Structure API Jan 2, 2026
@mrlubos mrlubos merged commit fc1514a into main Jan 2, 2026
18 of 24 checks passed
@mrlubos mrlubos deleted the fix/sdk-class-conflict branch January 2, 2026 04:52
@hey-api hey-api bot mentioned this pull request Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Broken or incorrect behavior. size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect class split logic for SDK when asClass: true Missing methods with nested operation ID's with class SDKs

3 participants