Skip to content

Comments

Rob's code to adapt to Nathan's formats based on Nimesha's code #95

Open
RobertLRead wants to merge 9 commits intomainfrom
robAdaptToNathan
Open

Rob's code to adapt to Nathan's formats based on Nimesha's code #95
RobertLRead wants to merge 9 commits intomainfrom
robAdaptToNathan

Conversation

@RobertLRead
Copy link
Collaborator

Dear @NimeshaKahingala,

I THINK I created this branch from your branch. On Sunday, James and I with worked with Nathan together on this, and with Nathan's help I got it working, accomplishing two things:

  1. I now have NOT hard-wired the cookie recipe (so taht we are matching against an arbitrary OKH), and
  2. I made the GUI (and the back-end summary code) able to handle either the "old" OKH format which we used or the "new" OKH format which Nathan has created in the last 2 months. (This was done with the typescript nullarity operator "??".

I beileve this should be merged to main immediately, but James and I want you to review it by Thursday and to merge it on Thursday. (If you don't get back to us, we will likely merge on Sunday.)

@Jbutler-helpful
Copy link
Collaborator

@NimeshaKahingala any thoughts about this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants