Rob's code to adapt to Nathan's formats based on Nimesha's code #95
Open
RobertLRead wants to merge 9 commits intomainfrom
Open
Rob's code to adapt to Nathan's formats based on Nimesha's code #95RobertLRead wants to merge 9 commits intomainfrom
RobertLRead wants to merge 9 commits intomainfrom
Conversation
…support the new format
Collaborator
|
@NimeshaKahingala any thoughts about this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @NimeshaKahingala,
I THINK I created this branch from your branch. On Sunday, James and I with worked with Nathan together on this, and with Nathan's help I got it working, accomplishing two things:
I beileve this should be merged to main immediately, but James and I want you to review it by Thursday and to merge it on Thursday. (If you don't get back to us, we will likely merge on Sunday.)