Worked on making script logging more uniform #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors logging configuration across HED command-line scripts to create a more uniform approach. The changes centralize logging setup into a shared utility function and update the CLI commands to properly handle exit codes.
Changes:
- Centralized logging setup by using
setup_logging()fromscript_utils.pyinstead of duplicated implementations - Replaced print statement with proper debug logging in validate_bids.py
- Updated CLI commands to use
@click.pass_contextandctx.exit()for proper exit code handling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| hed/scripts/validate_bids.py | Replaced print statement with logger.debug() for argument logging |
| hed/scripts/hed_extract_bids_sidecar.py | Removed duplicate logging setup code and imported centralized setup_logging function |
| hed/scripts/extract_tabular_summary.py | Removed duplicate logging setup function and used centralized version |
| hed/cli/cli.py | Added context passing and proper exit code handling to all CLI commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.