Check correct channel avoiding multiple changes #587
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong stored channel was checked when seeing if a channel change is actually required. This caused the goggles to try to change channels multiple times as the backpack sends the command 3 times to ensure that one gets through. This also interacted with a bug in the VTX Admin code where the SPI based receivers save the channel to betaflight flash which causes an interruption in the connection, when the connection is re-established another VTXAdmin command was sent because the debounce was too short and got into an infinite loop. See ExpressLRS/ExpressLRS#3488