fix: use openstack as hcp metadata provider name #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously was using the default value which had the 'mitchellh.' prefix
anurag5sh
reviewed
Dec 3, 2025
| artifact := &Artifact{ | ||
| ImageId: "foo", | ||
| BuilderIdValue: "openstack", | ||
| BuilderIdValue: "mitchellh.openstack", |
Contributor
There was a problem hiding this comment.
Just curious, is this change made to avoid breaking this particular test?
Contributor
Author
There was a problem hiding this comment.
This test is to make sure that it doesn't prepend the mitchellh when fetching the ProviderName (problem with UI openstack icon rendering)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously was using the default value which had the
mitchellh.prefixTo be consistent with other plugin, we need to remove the prefix. (also help with showing the right icon in HCP)
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.