Conversation
Signed-off-by: yamashush <38120991+yamashush@users.noreply.github.com> Signed-off-by: Ali Bellamine <bellamine@elsan.care>
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com> Signed-off-by: Ali Bellamine <bellamine@elsan.care>
Signed-off-by: Ali Bellamine <bellamine@elsan.care>
Signed-off-by: Ali Bellamine <bellamine@elsan.care>
|
I was wondering why a migration was created to add an index in this PR? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the SQLite connection in the docker image by adjusting the migration logic for adding and removing the index on the "Revisions" table.
- Adds a migration to create an index on the "noteId" column
- Provides a down migration to remove the index
Files not reviewed (1)
- deployments/docker-entrypoint.sh: Language not supported
| }, | ||
|
|
||
| down: (queryInterface, Sequelize) => { | ||
| return queryInterface.removeIndex('Revisions', 'noteId') |
There was a problem hiding this comment.
The down migration is attempting to remove an index using the name 'noteId', but the up migration does not explicitly name the index. Consider providing an explicit index name in queryInterface.addIndex so that removeIndex can reference the correct name.
|
Hi @alibell, |
The current docker image doesn't work with SQLite.
There are two main issues :
The current fix resolve these two issues.