Skip to content

feat: support readBytes(ByteBuffer dest) for OkHttpReadableBuffer #12577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NguyenHoangSon96 wants to merge 1 commit into from
Closed

feat: support readBytes(ByteBuffer dest) for OkHttpReadableBuffer #12577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions okhttp/src/main/java/io/grpc/okhttp/OkHttpReadableBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ public void readBytes(byte[] dest, int destOffset, int length) {

@Override
public void readBytes(ByteBuffer dest) {
// We are not using it.
throw new UnsupportedOperationException();
try {
buffer.read(dest);
} catch (IOException e) {
throw new RuntimeException(e);
}
}

@Override
Expand Down
6 changes: 0 additions & 6 deletions okhttp/src/test/java/io/grpc/okhttp/OkHttpReadableBufferTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ public void setup() {
}
}

@Override
@Test
public void readToByteBufferShouldSucceed() {
// Not supported.
}

@Override
@Test
public void partialReadToByteBufferShouldSucceed() {
Expand Down