fix: prevent preventing default behaviour on click on blur #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draedful
changed the title
Contributor
|
Preview is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not call preventDefault when clicking on an anchor or block in ConnectionLayer.
Due to the fact that ConnectionLayer was listening to events on the graph and, when mousedown fired over anchor or block, was preparing to listen to further drag, it called preventDefault, which broke the blur event call on inputs.
Previously, preventDefault was called so that mousedown events on the camera would not be triggered and pan would not be triggered. Instead, I added stopGraphEventPropagation, which does the same thing in terms of graph behavior, but does not prevent the browser from processing events.