feat(useSignal): refactor useSignal to use useSyncExternalState #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
draedful
changed the title
draedful
force-pushed
the
more_hooks
branch
2 times, most recently
from
6a6b48d to
587578c
Compare
Antamansid
approved these changes
Feb 2, 2026
| return { | ||
| ...options, | ||
| }; | ||
| }, [options.frameInterval, options.frameTimeout, options.priority]); |
Collaborator
There was a problem hiding this comment.
Options here and below are optional. It's better to add question marks here, otherwise it will be an error that options are undefined.
Actual for: useSchedulerDebounce, useSchedulerThrottle, useScheduledTask.
Collaborator
Author
There was a problem hiding this comment.
Yes, this is a mistake - options should be required
| return state.block.$geometry.subscribe(() => { | ||
| refreshAnchorPosition(); | ||
| }); | ||
| }, [state.block]); |
Collaborator
There was a problem hiding this comment.
Think here same? State may be undefined.
Maybe state?.block.
| }); | ||
| }, [viewState]); | ||
|
|
||
| const containerClassNames = useMemo(() => { |
Collaborator
There was a problem hiding this comment.
nit: Think we can do without usememo here.
Nevertheless, of course, it's easier to read this way, I agree.
feat: add hooks to compute/effect signal feat: add hook to scheduling task feat: add hook to handle scene changes(camera+hitbox)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add hooks to compute/effect signal
feat: add hook to scheduling task
feat: add hook to handle scene changes(camera+hitbox)