fix(sec): set default maximum batching size to 500 to prevent Denial-of-Service #364
Open
hainenber wants to merge 2 commits intographql:mainfrom
Open
fix(sec): set default maximum batching size to 500 to prevent Denial-of-Service #364hainenber wants to merge 2 commits intographql:mainfrom
hainenber wants to merge 2 commits intographql:mainfrom
Conversation
… of Service Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
changed the title
saihaj
requested changes
Dec 3, 2024
Member
saihaj
left a comment
saihaj
left a comment
There was a problem hiding this comment.
I would consider this as a breaking change. We are changing a default limit and potentially for someone it can start breaking the CI if they don't adjust this limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A light attempt to resolve SNYK-JS-DATALOADER-8248488 by setting up a default maxBatchSize to be 500.
The limit is chosen arbitrarily along with inspiration from Elastic's Beats equivalent