This repository was archived by the owner on Jan 12, 2019. It is now read-only.
Secured undefined path for existing refBuilders.#163
Open
kleeb wants to merge 1 commit intogooglearchive:masterfrom
Open
Secured undefined path for existing refBuilders.#163kleeb wants to merge 1 commit intogooglearchive:masterfrom
kleeb wants to merge 1 commit intogooglearchive:masterfrom
Conversation
For any usage of refBuilder, ref.parent is undefined. This causes the method to break and not index records at all.
Contributor
|
For any usage? Examples? Are these all on the root path? |
katowulf
suggested changes
May 10, 2017
| }; | ||
|
|
||
| exports.pathName = function(ref) { | ||
| if(typeof ref.parent === 'undefined') return ref.path; |
Contributor
There was a problem hiding this comment.
I don't see ref.path in the reference guide. Guessing a better answer here would be ref.ref.key, as that should work fine with Query and DatabaseReference instances?
Author
There was a problem hiding this comment.
I don't see any usages except console.logs for this one, so more or less we can put anything here, so that the function does not throw exception and break the code flow. For my refBuilder ref.path was returning the path of monitor.
The main case is that for any refBuilder functions ref.parent is undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For any usage of refBuilder, ref.parent is undefined. This causes the method to break and not index records at all.