docs: update the README instructions for running Spanner samples#1266
Open
aakashanandg wants to merge 2 commits intogoogleapis:mainfrom
Open
docs: update the README instructions for running Spanner samples#1266aakashanandg wants to merge 2 commits intogoogleapis:mainfrom
aakashanandg wants to merge 2 commits intogoogleapis:mainfrom
Conversation
olavloite
approved these changes
Dec 12, 2024
Contributor
olavloite
left a comment
There was a problem hiding this comment.
The change itself LGTM, but the pull request title needs to be changed. We use conventional commits to generate the release notes. This means that:
- All commits and pull request titles should start with a commit type (
feat:,docs:,fix:, etc.) In this case, the type should bedocs: - The rest of the header automatically goes into the release notes, so it should preferably be worded in a way that it reads naturally for someone reading it after it has been released. So in this case I would suggest
docs: update the README instructions for running Spanner samples
Contributor
Author
Got it! I've updated the PR description to follow the conventional commits guideline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<1265> 🦕