http2: Fix issue where slow requests are terminated prematurely#879
Open
hyperair wants to merge 2 commits intogoogleapis:mainfrom
Open
http2: Fix issue where slow requests are terminated prematurely#879hyperair wants to merge 2 commits intogoogleapis:mainfrom
hyperair wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Use `session.setTimeout` instead of `setTimeout` for the idle shutdown timer. Fixes: googleapis#768
FakeClient now needs a setTimeout function
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where http2 requests taking longer than 500ms will be terminated prematurely, with
http2.requestsilently resolving with truncated responses instead of rejecting with an error.The issue comes from starting the idle shutdown timer (500ms) immediately after the beginning of the latest request on the session, and not detecting that the session is still actively transferring data before forcefully terminating the session.
This PR fixes that by switching the connection idle shutdown timer to
session.setTimeoutinstead ofsetTimeout.I've also verified that this fix makes the client in https://github.com/hyperair/google-http2-bug-demo work correctly (more info here):
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #768 🦕