Add RDAP nameserver tests for .zz-- TLD hostnames #2936
Merged
+42
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This will be easier to review once #2935 gets merged and this can be rebased on it (as it depends on changes in that PR). |
CydeWeys
force-pushed
the
rdap-zz-hostnames
branch
2 times, most recently
from
6036e99 to
9fa35b7
Compare
Member
Author
OK it's rebased now and ready for review. |
The actual error is fixed as a side effect of PR google#2935, but this adds tests verifying the intended behavior. BUG= http://b/476144993
CydeWeys
force-pushed
the
rdap-zz-hostnames
branch
from
9fa35b7 to
26f70f8
Compare
weiminyu
approved these changes
Jan 16, 2026
Collaborator
weiminyu
left a comment
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RDAP nameserver tests for .zz-- TLD hostnames
The actual error is fixed as a side effect of PR #2935, but this adds tests verifying the intended behavior.
BUG= http://b/476144993
This change is