Fee extension 1.0 fix #2912
Open
Fee extension 1.0 fix #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check command seem to work. Need to add more tests. Also need to go over other commands to ensure they are not affected.
gbrodman
added a commit
to gbrodman/nomulus
that referenced
this pull request
Jan 7, 2026
Many of the actual fee extension changes are based off Weimin's PR google#2912, though this makes some additional changes based on the XML schema and description from RFC 8748. This adds tests for the DomainCheckFlow which is the most complex and thorough user of the fee extension, but we'll want to add further tests to the other domain flows to make sure they're handled correctly.
gbrodman
added a commit
to gbrodman/nomulus
that referenced
this pull request
Jan 7, 2026
Many of the actual fee extension changes are based off Weimin's PR google#2912, though this makes some additional changes based on the XML schema and description from RFC 8748. This adds tests for the DomainCheckFlow which is the most complex and thorough user of the fee extension, but we'll want to add further tests to the other domain flows to make sure they're handled correctly.
gbrodman
added a commit
to gbrodman/nomulus
that referenced
this pull request
Jan 8, 2026
Many of the actual fee extension changes are based off Weimin's PR google#2912, though this makes some additional changes based on the XML schema and description from RFC 8748. This adds tests for the DomainCheckFlow which is the most complex and thorough user of the fee extension, but we'll want to add further tests to the other domain flows to make sure they're handled correctly.
gbrodman
added a commit
to gbrodman/nomulus
that referenced
this pull request
Jan 9, 2026
Many of the actual fee extension changes are based off Weimin's PR google#2912, though this makes some additional changes based on the XML schema and description from RFC 8748. This adds tests for the DomainCheckFlow which is the most complex and thorough user of the fee extension, but we'll want to add further tests to the other domain flows to make sure they're handled correctly.
gbrodman
added a commit
to gbrodman/nomulus
that referenced
this pull request
Jan 9, 2026
Many of the actual fee extension changes are based off Weimin's PR google#2912, though this makes some additional changes based on the XML schema and description from RFC 8748. This adds tests for the DomainCheckFlow which is the most complex and thorough user of the fee extension, but we'll want to add further tests to the other domain flows to make sure they're handled correctly.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
Many of the actual fee extension changes are based off Weimin's PR #2912, though this makes some additional changes based on the XML schema and description from RFC 8748. This adds tests for the DomainCheckFlow which is the most complex and thorough user of the fee extension, but we'll want to add further tests to the other domain flows to make sure they're handled correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the RFC 8748 fee extension 1.0 properly.
This change is