refactor: Use sorting functions from slices instead of sort#4020
Merged
gmlewis merged 1 commit intogoogle:masterfrom Feb 16, 2026
Merged
refactor: Use sorting functions from slices instead of sort#4020gmlewis merged 1 commit intogoogle:masterfrom
slices instead of sort#4020gmlewis merged 1 commit intogoogle:masterfrom
Conversation
alexandear
changed the title
slices instead of sortslices instead of sort
alexandear
force-pushed
the
chore/slices-sort
branch
from
988e418 to
0c4bf6c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4020 +/- ##
==========================================
- Coverage 94.04% 94.04% -0.01%
==========================================
Files 207 207
Lines 19174 19170 -4
==========================================
- Hits 18033 18029 -4
Misses 939 939
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Feb 16, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because sorting functions from the
slicespackage are easier to use than those insort.