-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update user_content initialization to None, handle System only event in Evaluation #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change user_content initialization from empty string to None for better clarity. Added condition to skip evaluation when user input is None, as this is required for Evaluation
Summary of ChangesHello @kauabh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the evaluation generation process by improving how absent user input is handled. It changes the default initialization of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors the user_content initialization to use None instead of an empty string, which improves type safety and code clarity. Additionally, it introduces a necessary check to skip evaluation for invocations lacking user input, preventing potential errors and focusing evaluations on meaningful interactions. The changes are sound. My review includes a minor style suggestion to remove an unnecessary whitespace-only line, in accordance with PEP 8.
|
It looks like you might have tried to invoke a command. The available commands are |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the initialization of user_content to None for improved clarity and introduces a condition to skip evaluation when user input is absent. This change addresses the stated goal of handling cases without user input for evaluation purposes. A potential improvement has been identified regarding the handling of empty Content objects.
Change user_content initialization from empty string to None for better clarity. Added condition to skip evaluation when user input is None, as this is required for Evaluation. This closes issue #3760
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
I created a simple Root agent. Executed this adk web. After one interaction I chnaged "user" role from store database to "model". Without the proposed changes it code was failing as expected while creating evaluation set, after code changes it was running fine.
Checklist
Additional context
Add any other context or screenshots about the feature request here.