This repository was archived by the owner on Sep 24, 2025. It is now read-only.
you can skip adding empty dev file and infer time is reduced#70
Open
Akshaysharma29 wants to merge 1 commit intogoogle-research:masterfrom
Open
you can skip adding empty dev file and infer time is reduced#70Akshaysharma29 wants to merge 1 commit intogoogle-research:masterfrom
Akshaysharma29 wants to merge 1 commit intogoogle-research:masterfrom
Conversation
eisenjulian
suggested changes
Nov 3, 2020
Contributor
eisenjulian
left a comment
eisenjulian
left a comment
There was a problem hiding this comment.
Thanks for the proposed changes, it's a great idea to make inference faster when no test set is needed. To make it not fail silently in the case of missing data, we would prefer if we added an explicit boolean flag to the executable, something like skip_test_set so we can use that in the loops over TestSet to skip the evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team, I have added a check so creating an empty dev file can be skipped in colab and this will reduce infer time as well.
Thanks.