Skip to content

Conversation

@afonsojramos
Copy link
Member

Summary

  • Disable the useUniqueElementIds biome lint rule

Rationale

This rule warns against hardcoded id attributes and suggests using React's useId() hook. However, this is inappropriate for an Electron app:

  1. No SSR - useId() was designed to solve hydration mismatch issues between server and client. Gitify is a desktop app with no server rendering.
  2. No collision risk - Components like filters render once per page, not in dynamic lists where ID collisions could occur.
  3. Worse DX - Replaces readable IDs like filter-state with opaque generated IDs like :r1:, making debugging harder.

Test plan

  • Lint passes with rule disabled

@github-actions github-actions bot added the chore Miscellaneous tasks label Dec 29, 2025
@afonsojramos afonsojramos merged commit 82572b2 into main Dec 29, 2025
9 checks passed
@afonsojramos afonsojramos deleted the feat/react-id branch December 29, 2025 00:35
@github-actions github-actions bot added this to the Release 6.15.0 milestone Dec 29, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Miscellaneous tasks

Development

Successfully merging this pull request may close these issues.

3 participants