Skip to content

Conversation

@afonsojramos
Copy link
Member

Summary

Changes

  • ReasonFilter: id="filter-reasons" -> useId()
  • StateFilter: id="filter-state" -> useId()
  • SubjectTypeFilter: id="filter-subject-type" -> useId()
  • UserTypeFilter: id="filter-user-types" -> useId()

Test plan

  • All existing tests pass
  • Snapshots updated to reflect new ID format

@github-actions github-actions bot added the refactor Refactoring of existing feature label Dec 29, 2025
@sonarqubecloud
Copy link

@afonsojramos
Copy link
Member Author

After opening this PR, I did some thinking, instead of trusting the linter, and I think that to be honest, useId() doesn't really make sense here. Since this is client-only, no SSR, and useId() was designed to solve hydration mismatch issues, specifically, between server and client.

@setchy
Copy link
Member

setchy commented Dec 29, 2025

Makes sense, good pickup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring of existing feature

Development

Successfully merging this pull request may close these issues.

3 participants