-
Notifications
You must be signed in to change notification settings - Fork 155
Add footer boolean field to safe-output configurations (individual and global) #15079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c558440
b1e373d
9b5de63
7488335
2455d4e
8284bc8
cd52e69
f60f273
7ed2012
3c0a4ab
ba5fe1f
0f3fdb2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,15 +71,16 @@ function findIsland(body, runId) { | |
| * @param {string} params.workflowName - Name of the workflow | ||
| * @param {string} params.runUrl - URL of the workflow run | ||
| * @param {number} params.runId - Workflow run ID | ||
| * @param {boolean} [params.includeFooter=true] - Whether to include AI-generated footer (default: true) | ||
| * @returns {string} Updated body content | ||
| */ | ||
| function updateBody(params) { | ||
| const { currentBody, newContent, operation, workflowName, runUrl, runId } = params; | ||
| const aiFooter = buildAIFooter(workflowName, runUrl); | ||
| const { currentBody, newContent, operation, workflowName, runUrl, runId, includeFooter = true } = params; | ||
| const aiFooter = includeFooter ? buildAIFooter(workflowName, runUrl) : ""; | ||
|
|
||
| if (operation === "replace") { | ||
| // Replace: use new content with AI footer | ||
| core.info("Operation: replace (full body replacement with footer)"); | ||
| // Replace: use new content with optional AI footer | ||
| core.info("Operation: replace (full body replacement)"); | ||
| return newContent + aiFooter; | ||
| } | ||
|
Comment on lines
+78
to
85
|
||
|
|
||
|
|
@@ -109,7 +110,7 @@ function updateBody(params) { | |
| } | ||
|
|
||
| if (operation === "prepend") { | ||
| // Prepend: add content, AI footer, and horizontal line at the start | ||
| // Prepend: add content, AI footer (if enabled), and horizontal line at the start | ||
| core.info("Operation: prepend (add to start with separator)"); | ||
| const prependSection = `${newContent}${aiFooter}\n\n---\n\n`; | ||
| return prependSection + currentBody; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildDiscussionUpdateDatasetsupdateData._includeFooter, butexecuteDiscussionUpdatenever reads it and the handler never usesupdateBody/footer generation. As-is,safe-outputs.update-discussion.footerhas no effect. Either implement footer handling for discussion body updates (and strip internal fields before sending to GraphQL), or remove_includeFooteruntil it’s supported.