-
Notifications
You must be signed in to change notification settings - Fork 136
Remove inline CSS styling from tokens.mdx using Astro Starlight components #14998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 PR Triage ResultsCategory: docs | Risk: low | Priority: 15/100 Scores Breakdown
📋 Recommended Action: deferWIP draft PR for documentation styling. Wait for author to complete checklist and mark ready for review. Triaged by PR Triage Agent on 2026-02-11T18:30:00Z - Run #21917749368
|
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
pelikhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove use of single cards elements for token section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Tokens reference documentation page to remove inline styling/custom layout markup and instead use Astro Starlight’s Card / CardGrid components for a more theme-consistent presentation.
Changes:
- Introduces Starlight
Card/CardGridcomponents to present token reference sections as cards. - Replaces inline-styled layout wrappers (padding-left divs, custom grid divs, styled badges) with markdown + Starlight components.
- Simplifies screenshot markup by removing custom wrapper elements and leaving plain
<picture>blocks.
Comments suppressed due to low confidence (1)
docs/src/content/docs/reference/tokens.mdx:69
- In the ownership examples, the explanatory text is no longer semantically tied to the images (it used to be a caption block). Consider using
<figure>/<figcaption>inside each Card (or otherwise marking the text as a caption) to preserve the image–caption relationship for accessibility.
<CardGrid>
<Card title="User-owned repository">
<picture>
<source media="(prefers-color-scheme: dark)" srcSet="/gh-aw/images/user-owned_dark.png" />
<img alt="User-owned repository example" src="/gh-aw/images/user-owned_light.png" />
</picture>
Avatar shows a personal profile icon, URL includes username
</Card>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcSet="/gh-aw/images/actions-secrets_dark.png" /> | ||
| <img alt="Repository secrets page showing configured tokens" src="/gh-aw/images/actions-secrets_light.png" /> | ||
| </picture> |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub UI screenshot used to have an explicit caption (and role="note") but it’s now just a <picture> with no accompanying caption text. Consider wrapping this in a semantic <figure>/<figcaption> (or adding a short caption paragraph immediately after) so the context isn’t lost for screen-reader users and people skimming the page.
This issue also appears on line 61 of the same file.
|
|
||
| Avatar shows a personal profile icon, URL includes username | ||
| </Card> | ||
|
|
||
| <div> | ||
| <picture style={{margin: '0 !important'}}> | ||
| <Card title="Organization-owned repository"> | ||
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcSet="/gh-aw/images/org-owned_dark.png" /> | ||
| <img alt="Organization-owned repository example" src="/gh-aw/images/org-owned_light.png" style={{width: '100%', height: 'auto', display: 'block', margin: '0 !important'}} /> | ||
| <img alt="Organization-owned repository example" src="/gh-aw/images/org-owned_light.png" /> | ||
| </picture> | ||
| <div class="gh-aw-video-caption" role="note" style={{marginTop: '0.5rem'}}> | ||
| Organization-owned repository: avatar shows organization icon, URL includes org name | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| Avatar shows organization icon, URL includes org name |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are whitespace-only lines inside the <Card> bodies (e.g., between </picture> and the caption text). These can create noisy diffs and may trigger trailing-whitespace checks in some pipelines; consider removing the indentation-only blank lines.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Removed all Card components from token sections. The CardGrid with two Cards for ownership examples is kept as it provides a cleaner side-by-side layout than styled divs. Fixed in cb720eb. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Removes all inline styles and custom CSS from the tokens reference page, replacing them with clean markdown and Astro Starlight's
CardGridcomponent for the ownership examples section.Changes
CardandCardGridfrom@astrojs/starlight/components<span style="...">) and wrapper divs (<div style="padding-left: 1.5rem;">) from all token reference sections, using clean markdown instead<CardGrid>containing two<Card title="...">components for side-by-side comparison<div style="padding-left: 1.5rem;">wrappers, using clean markdownBefore:
After:
Result: Zero inline styles, clean markdown structure, maintained functionality. The CardGrid component is used only for the ownership comparison section to provide a better layout than inline-styled divs.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.